Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential refactoring: proper use of context in readbuffer #70

Open
moio opened this issue Mar 8, 2024 · 0 comments
Open

Potential refactoring: proper use of context in readbuffer #70

moio opened this issue Mar 8, 2024 · 0 comments

Comments

@moio
Copy link
Contributor

moio commented Mar 8, 2024

reabuffer.go code seems prone to leaks, race conditions and similar bugs because of its use of Cond (which is generally discouraged) and the lack of "typical" use of contexts.

Although I am not aware of any new specific bug, I believe a refactoring of this part could be beneficial for future readers given the crucial importance of this piece of architecture to the whole Rancher product family.

cc @aruiz14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants