Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove overlapping functionality in rancher2_machine_config_v2 #956

Closed
02bensch opened this issue Jul 14, 2022 · 0 comments
Closed

Remove overlapping functionality in rancher2_machine_config_v2 #956

02bensch opened this issue Jul 14, 2022 · 0 comments

Comments

@02bensch
Copy link
Contributor

Within the rancher2_machine_config_v2's azure_config arguments, there is an overlap between no_public_ip and private_address_only. @eliyamlevy and I think it makes sense to remove the no_public_ip argument so that the azure_config is more closely aligned with amazonec2_config and it's arguments - as discussed here #876.
This was referenced Jul 14, 2022
Merged
Closed
@kkaempf kkaempf linked a pull request Dec 8, 2023 that will close this issue
Remove no_public_ip argument from azure machine_config #961
Closed
@02bensch 02bensch closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
@zube zube bot closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove no_public_ip argument from azure machine_config 02bensch/terraform-provider-rancher2
1 participant
@02bensch