Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower js files to dist? #39

Open
bichotll opened this issue Apr 15, 2015 · 1 comment
Open

Bower js files to dist? #39

bichotll opened this issue Apr 15, 2015 · 1 comment

Comments

@bichotll
Copy link

Hi,
I've just noticed that you are copying the js files to dist?
I think that's not necessary as it already is building a vendor js file of all the third party ones.

https://github.com/randylien/generator-react-gulp-browserify/blob/master/app/templates/_gulpfile.js#L149

@codeofsumit
Copy link

codeofsumit commented May 2, 2016

That's correct for JS files. CSS files however are not being bundled into a vendor.css

so these are the problems:

  • Bower files are copies to dist, with all source files
  • CSS libs in bower aren't bundled into a vendor.css
  • Even with the bower files inside dist, CSS links don't seem to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants