This repository has been archived by the owner on May 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 216
Massive refactoring of entire backend and most of the frontend #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serialize componentInstance only when the node has actually been selected by the user and is going to be displayed in the righthand panel. This saves us the performance cost of serializing the componentInstance property of each node and is made possible by the new request-response messaging system
- Fix up some styling
* Fix highlighting nodes when they change * Upgrade typings
@clbond, thanks for your PR! By analyzing the annotation information on this pull request, we identified @sumitarora, @vanessayuenn and @winkerVSbecks to be potential reviewers |
Two things I did not finish implementing:
But I don't think these are big enough issues to stop the PR. I would like to get it merged because it's such a drastic departure that the merge conflicts are going to be unbelievably difficult to deal with. Basically every line that gets changed between now and when this PR gets merged is going to conflict. |
export interface Property { | ||
key: string; | ||
value: string; | ||
value; | ||
} | ||
|
||
export abstract class Description { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clbond I don't think we are gaining anything from making this class abstract
😬 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the entire backend and the majority of the frontend code in Augury. I apologize because it is a massive huge commit that no reasonable person would want to review all the way through. But since it was such a thorough refactoring, I was not able to submit discrete pieces of work in small PRs. Anyway here is what this PR changes:
If you have an interest in this PR I strongly suggest cloning it and running the application, checking it out, checking for bugs, etc etc.