Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo Editing Improvements #187

Closed
1 of 5 tasks
9z0 opened this issue Jul 2, 2021 · 11 comments
Closed
1 of 5 tasks

Todo Editing Improvements #187

9z0 opened this issue Jul 2, 2021 · 11 comments

Comments

@9z0
Copy link

9z0 commented Jul 2, 2021

Checklist:


  • (Text option) Don't offer a context/project if already assigned to the todo.

  • If sugestions are shown, you should hide suggestions (like pressing Esc) by clicking on a part of the edit box other than the suggestions box (or the text field). For example, the surrounding white. Clicking outside the whole edit box should close editing as usual.

  • (Text option) Don't automatically add creation date.

@9z0
Copy link
Author

9z0 commented Jul 6, 2021

Steps:

  1. Click a todo.
  2. Make some changes.
  3. Click outside edit box.

Actual: editing is cancelled and no changes are saved.

Suggested: show a confirmation to avoid losing changes.

Reason: mistaken closure happens, especially that the save button is close to the edge.

@ransome1
Copy link
Owner

ransome1 commented Jul 6, 2021

Steps:

  1. Click a todo.
  2. Make some changes.
  3. Click outside edit box.

Actual: editing is cancelled and no changes are saved.

Suggested: show a confirmation to avoid losing changes.

Reason: mistaken closure happens, especially that the save button is close to the edge.

This one is added in the next version. The confirmation will only be shown if there has been an edit to the text field.

(Text option) Don't automatically add creation date.

Can you explain why and what "Text option" means?

Also I would suggest that we collect any requirement in the inital post by editing it. It is somehow confusing if requirements appear in following postsor in the middle of a discussion.

@9z0
Copy link
Author

9z0 commented Jul 6, 2021

This one is added in the next version. The confirmation will only be shown if there has been an edit to the text field.

👍

(Text option) Don't automatically add creation date.

It means a setting in config file(s), but not in the UI (like here: #151) to keep the UI simple. Is there a clearer way to describe these?

Also I would suggest that we collect any requirement in the inital post by editing it. It is somehow confusing if requirements appear in following postsor in the middle of a discussion.

No problem. I will keep a checklist in the top post for reference.

@ransome1
Copy link
Owner

ransome1 commented Jul 7, 2021

Steps:

  1. Click a todo.
  2. Make some changes.
  3. Click outside edit box.

Actual: editing is cancelled and no changes are saved.

Suggested: show a confirmation to avoid losing changes.

Reason: mistaken closure happens, especially that the save button is close to the edge.

This one is available in https://github.com/ransome1/sleek/releases/tag/v1.0.9-rc.1

@9z0
Copy link
Author

9z0 commented Jul 9, 2021

When a project/context popup is show, allow ctrl +click to select more than one project (similar to how you select multiple files in a file manager).

During that, always keep showing the list as-is until the user clicks away or clicks on a project without ctrl. For example, If I typed +lor to show only some projects, don't close the list or reset the filter after the ctrl+click. Keep the same filtered suggestions.

@9z0
Copy link
Author

9z0 commented Jul 26, 2021

Bug:

  • Open edit box and make changes
  • Click outside the box. The "cancel edits" confirmation appears.
  • Click outside the confirmation message.

Expected:

  • Nothing happens. You can only take action by clicking "Confirm" or "Cancel".

Actual:

  • The message is dismissed with confirmation (The edits are lost).

@ransome1
Copy link
Owner

Bug:

  • Open edit box and make changes
  • Click outside the box. The "cancel edits" confirmation appears.
  • Click outside the confirmation message.

Expected:

  • Nothing happens. You can only take action by clicking "Confirm" or "Cancel".

Actual:

  • The message is dismissed with confirmation (The edits are lost).

This is added to the final 1.10.

@aleksfadini
Copy link

Would love to be able to select more than one task with shift or click. Adding a context or a project to multiple tasks is now a bit clunky.

@9z0
Copy link
Author

9z0 commented Aug 4, 2021

@aleksfadini

The other topic (#56) you commented on is the right one.

This issue is about the edit box that appears when you click a todo. :)

@aleksfadini
Copy link

aleksfadini commented Aug 4, 2021 via email

@github-actions
Copy link

This is an automated response. We acknowledge your report, and we appreciate your engagement. However, as there has been no recent activity in this thread, it has been marked as stale. If you have any further feedback or if the matter is still relevant, please do not hesitate to respond. Otherwise, this thread will be automatically closed in 15 days from now.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants