Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win + D shortcut on Linux seems problematic #591

Closed
andrei-a-papou opened this issue Nov 26, 2023 · 6 comments
Closed

Win + D shortcut on Linux seems problematic #591

andrei-a-papou opened this issue Nov 26, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@andrei-a-papou
Copy link

Bug Report

App Version: 2.0.2

Platform: Linux, Debian 11, Xfce

Installation Method: AppImage from GitHub

Bug Description:
Win + D ("hide app") shortcut doesn't work on my machine, in fact, the Win modifier doesn't even register (see screenshot):
image

There's no conflict with window manager's keybindings on my machine, but I imagine some people do use Win + D to toggle desktop (a-la Windows).

In addition, clicking the Hide menu item doesn't do anything either.

Personally, I would remove this functionality on Linux as it is rather trivial to implement with third-party apps (e.g. jumpapp) or a bit of scripting (using wmctrl or similar.) That would also ensure there's no conflict with window manager's key bindings.

@andrei-a-papou andrei-a-papou added the bug Something isn't working label Nov 26, 2023
@ransome1
Copy link
Owner

@andrei-a-papou I can confirm, this menu entry has no effect on Linux (I have Ubuntu/Gnome running in a VM here).

Generally, if hiding windows on Linux desktop environments is not common, I agree and we might want to simply remove it from the menu.

Are you familiar with Windows? From what I understand, Windows + D is the OS default keyboard binding to show the desktop and more or less hide all elements, which are currently in foreground. If this is true, I also don't see any good reason to register a keyboard shortcut in sleek, which will never be triggered, since Windows will intercept it anyways. What do you think?

However, on macOS this shortcut (CMD+D) is commonly used.

@ransome1 ransome1 moved this to Backlog in sleek 2.x Nov 26, 2023
@andrei-a-papou
Copy link
Author

andrei-a-papou commented Nov 26, 2023

@ransome1 Yes, under Windows Win + D is a hardcoded thing, to show/hide desktop. I can confirm this on Windows 7 (virtual machine). For Windows 10 and 11 it's the same, see this link: https://support.microsoft.com/en-us/windows/keyboard-shortcuts-in-windows-dcc61a57-8ff0-cffe-9796-cb9706c75eec#WindowsVersion=Windows_10.

@ransome1
Copy link
Owner

Ok, I will remove this function for Windows and Linux in the next release. Thanks for pointing this out.

@ransome1 ransome1 moved this from Backlog to In Progress in sleek 2.x Nov 26, 2023
@andrei-a-papou
Copy link
Author

no problem!

@ransome1
Copy link
Owner

@andrei-a-papou the keyboard shortcut for hiding the window should be removed on Linux and Windows in this pre-release: https://github.com/ransome1/sleek/releases/tag/v2.0.3-rc.4

@andrei-a-papou
Copy link
Author

Just tested, the menu item's gone, thank you!

@github-project-automation github-project-automation bot moved this from In Progress to Done in sleek 2.x Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants