Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pyproject.toml #210

Closed
banesullivan opened this issue Dec 17, 2023 · 3 comments · Fixed by #205
Closed

Migrate to pyproject.toml #210

banesullivan opened this issue Dec 17, 2023 · 3 comments · Fixed by #205
Labels
PyOpenSci Review Issues related to the review for PyOpenSci

Comments

@banesullivan
Copy link
Contributor

Tracking a comment from @jhkennedy in pyOpenSci/software-submission#138 (comment) here:

It's time to move from setup.py to pyproject.toml

While setup.py is not technically deprecated, ref https://packaging.python.org/en/latest/discussions/setup-py-deprecated/, pyproject.toml is the new standardized format to describe project metadata declaratively, introduced with PEP 621. It's easier to work with and allows for shared configuration between different tools.

@raphaelquast raphaelquast added the PyOpenSci Review Issues related to the review for PyOpenSci label Dec 18, 2023
@raphaelquast
Copy link
Owner

There is now a (work-in-progress) PR to switch to pyproject.toml: #216

@raphaelquast raphaelquast linked a pull request Dec 19, 2023 that will close this issue
2 tasks
@raphaelquast raphaelquast linked a pull request Jan 2, 2024 that will close this issue
@raphaelquast
Copy link
Owner

#216 is now merged into the dev branch!
EOmaps v8.0 (see #205) will incorporate the following changes:

  • switch from setup.py to pyproject.toml
  • minimal supported python version is v3.8
  • version is now single-sourced to pyproject.toml file (_version.py is removed)
  • optional dependency groups are implemented for pip install

@banesullivan
Copy link
Contributor Author

Fantastic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyOpenSci Review Issues related to the review for PyOpenSci
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants