Adjust caching.

Author: raphw

byte-buddy-dep/src/main/java/net/bytebuddy/description/method/ParameterList.java

@@ -154,9 +154,9 @@ abstract class ForLoadedExecutable<T> extends AbstractBase<ParameterDescription.
         protected final ParameterDescription.ForLoadedParameter.ParameterAnnotationSource parameterAnnotationSource;
 
         /**
-         * The number of parameters of this executable, or -1, if the size was not yet computed. This avoids recomputation
-         * what can lead to an unreasonable performance impact if placed on a hot execution path. This field is not
-         * volatile as the result is stable and can be recomputed from different threads.
+         * The number of parameters of this executable, 0 if the size was not yet computed, or -1 if the list is empty.
+         * This avoids recomputation what can lead to an unreasonable performance impact if placed on a hot execution
+         * path. This field is not volatile as the result is stable and can be recomputed from different threads.
          */
         private int size;
 
@@ -169,7 +169,6 @@ abstract class ForLoadedExecutable<T> extends AbstractBase<ParameterDescription.
         protected ForLoadedExecutable(T executable, ParameterDescription.ForLoadedParameter.ParameterAnnotationSource parameterAnnotationSource) {
             this.executable = executable;
             this.parameterAnnotationSource = parameterAnnotationSource;
-            size = -1;
         }
 
         /**
@@ -236,10 +235,11 @@ public static ParameterList<ParameterDescription.InDefinedShape> of(Method metho
          * {@inheritDoc}
          */
         public int size() {
-            if (size == -1) {
-                size = EXECUTABLE.getParameterCount(executable);
+            if (size == 0) {
+                int size = EXECUTABLE.getParameterCount(executable);
+                this.size = size == 0 ? -1 : size;
             }
-            return size;
+            return size == -1 ? 0 : size;
         }
 
         /**
@@ -584,9 +584,9 @@ class TypeSubstituting extends AbstractBase<ParameterDescription.InGenericShape>
         private final TypeDescription.Generic.Visitor<? extends TypeDescription.Generic> visitor;
 
         /**
-         * The number of parameters of this executable, or -1, if the size was not yet computed. This avoids recomputation
-         * what can lead to an unreasonable performance impact if placed on a hot execution path. This field is not
-         * volatile as the result is stable and can be recomputed from different threads.
+         * The number of parameters of this executable, 0 if the size was not yet computed, or -1 if the list is empty.
+         * This avoids recomputation what can lead to an unreasonable performance impact if placed on a hot execution
+         * path. This field is not volatile as the result is stable and can be recomputed from different threads.
          */
         private int size;
 
@@ -603,7 +603,6 @@ public TypeSubstituting(MethodDescription.InGenericShape declaringMethod,
             this.declaringMethod = declaringMethod;
             this.parameterDescriptions = parameterDescriptions;
             this.visitor = visitor;
-            size = -1;
         }
 
         /**
@@ -617,10 +616,11 @@ public ParameterDescription.InGenericShape get(int index) {
          * {@inheritDoc}
          */
         public int size() {
-            if (size == -1) {
-                size = parameterDescriptions.size();
+            if (size == 0) {
+                int size = parameterDescriptions.size();
+                this.size = size == 0 ? -1 : size;
             }
-            return size;
+            return size == -1 ? 0 : size;
         }
     }