Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make User-Agent easier to control across modules and more consistent #4933

Closed
hdm opened this issue Mar 16, 2015 · 6 comments
Closed

Make User-Agent easier to control across modules and more consistent #4933

hdm opened this issue Mar 16, 2015 · 6 comments

Comments

@hdm
Copy link
Contributor

hdm commented Mar 16, 2015

Source http://blog.didierstevens.com/2015/03/16/quickpost-metasploit-user-agent-strings/

@Chiggins
Copy link
Contributor

Not knowing much about the source and how options are handled, but what if Metasploit had one default User-Agent string and all modules used that, unless otherwise specified via set/setg?

@hdm
Copy link
Contributor Author

hdm commented Mar 16, 2015

That is mostly the case today, but some modules redefine the default, this ticket would be to clear those defaults and rely on a consistent option (such as the one the HttpClient mixin offers).

@OJ
Copy link
Contributor

OJ commented Mar 16, 2015

Could be fun to have a generator that generates UA strings so that each case is different :)

@pyrohaz4good
Copy link

@hmoore-r7 Didier's post is very must the exact reason for #4984 :-)

@wchen-r7
Copy link
Contributor

wchen-r7 commented Jul 3, 2015

Some modules don't really need to redefine the user-agent. But it looks like most of them are pretty old so it's kind of hard to find the vulnerable software and verify (especially the memory corruption ones).

@bcook-r7
Copy link
Contributor

We added a common user agent list to meterpreter, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants