Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support sample_incoming_edges and sample_outgoing_edges to uniform neighborhood sampling #2468

Closed
Tracked by #3280
VibhuJawa opened this issue Jul 28, 2022 · 2 comments
Assignees

Comments

@VibhuJawa
Copy link
Member

Describe the solution you'd like and any additional context

We should support sample_incoming_edges and sample_outgoing_edges for the uniform neighborhood sampling algorithm.

Currently we only support sampling for outgoing edges .

For DGL the default behavior is to sample incoming edges instead of outgoing edges.

From the docs see below:

For each node, a number of inbound (default) (or outbound when edge_dir == 'out') edges will be randomly chosen. The graph returned will then contain all the nodes in the original graph, but only the sampled edges.

We also discussed potentially reversing the edges (See #2458 ) to get the incoming edges but adding the direction to the API might be easier and cleaner.

CC: @ChuckHastings , @seunghwak

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@ChuckHastings
Copy link
Collaborator

This can be accomplished today by creating the graph in the opposite direction. Do we need to address this at the C++ layer, or is it sufficient to add logic in some python layer to create the graph with store_transposed=True instead of store_transposed=False?

@alexbarghi-nv ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants