Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Non-specified nodes do not receive zero personalisation value in PageRank #961

Closed
ghost opened this issue Jun 22, 2020 · 4 comments
Closed
Assignees
Labels
bug Something isn't working question Further information is requested
Milestone

Comments

@ghost
Copy link

ghost commented Jun 22, 2020

NetworkX implements Personalised PageRank in such a way that any non-specified nodes receive a personalisation value of zero. [NX implementation]

In cuGraph, the user has to explicitly set the personalisation values for all other nodes to zero, or the results acquired do not seem to match those produced by NetworkX. If this is intended behaviour, it would be useful for the documentation to be updated making the difference clearer.

@ghost ghost added ? - Needs Triage Need team to review and classify bug Something isn't working labels Jun 22, 2020
@BradReesWork BradReesWork added question Further information is requested and removed ? - Needs Triage Need team to review and classify labels Jun 24, 2020
@BradReesWork BradReesWork added this to the 0.15 milestone Jun 24, 2020
@afender
Copy link
Member

afender commented Jun 24, 2020

Hi @nmkatri,

@kaatish and I were looking into this issue earlier and found that any non-specified nodes should receive a personalization value of zero in cuGraph too:


We also have tests running nightly and comparing personalized PageRank against NetworkX output and did not catch any mismatch recently.

We would like to investigate further and have the following questions at this time :

  1. Do you have steps and code to repro?
  2. Are you passing a personalization subset without setting any specified personalization values? cuGraph should currently fall back on regular Pagerank if that's the case.

@ghost
Copy link
Author

ghost commented Jun 25, 2020

Hi @afender,

Thank you very much for looking into this. I examined my code again and the mismatch seems to be caused by something other than cuGraph's personalised PageRank. This could very well be a bug in my code, but I haven't been able to pinpoint the exact cause yet.

In the process, though, I realised that running PageRank on a weighted network (like mine) produces results that don't match NX's. Here is the code and data to reproduce the issue: reprod.zip Please let me know if there's an issue with the code I'm using. In the meantime, I will continue investigating the original issue and keep you updated.

@kaatish
Copy link
Collaborator

kaatish commented Jun 25, 2020

Hi @nmkatri thanks for getting back. Unfortunately as we have mentioned in the documentation, our pagerank implementation does not make use of the edge weights.

If you do feel that it is an immediately required feature for you, please feel free to file a separate issue.

@afender afender closed this as completed Jul 8, 2020
@barondra
Copy link

barondra commented Dec 16, 2020

Dear @kaatish,
I have filed an issue #1313 regarding of edge weights for PPR. Please kindly give attention to the problem.
Thank you!
Edit: Issue #1313 has been addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants