Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Multi version install in the nightly container #2858

Open
Tracked by #4131
tfeher opened this issue Sep 22, 2020 · 6 comments
Open
Tracked by #4131

[BUG] Multi version install in the nightly container #2858

tfeher opened this issue Sep 22, 2020 · 6 comments
Labels
bug Something isn't working inactive-90d

Comments

@tfeher
Copy link
Contributor

tfeher commented Sep 22, 2020

Describe the bug
To install cuml in the nightly container, normally I just run python setup.py install from the cuml/python folder. Something has changed recently, and now the same command in nightly image does a multi version install.

In practice it means that instead of putting the code under /opt/conda/envs/rapids/lib/python3.7/site-packages/cuml, it is installed at something like /opt/conda/envs/rapids/lib/python3.7/site-packages/cuml-0.16.0a0+814.g461cbf2a7.dirty-py3.7-linux-x86_64.egg/cuml.

What is the correct way to install the python wrappers without any version suffix? I can work around by copying the files manually, but I guess there is a better solution than this:

cp -r /opt/conda/envs/rapids/lib/python3.7/site-packages/cuml-0.16.0a0+814.g461cbf2a7.dirty-py3.7-linux-x86_64.egg/cuml /opt/conda/envs/rapids/lib/python3.7/site-packages/

Steps/Code to reproduce bug

git clone https://github.com/rapidsai/cuml.git
nvidia-docker run -e HOST_USER_ID=0 -v$PWD:/mydata -w/mydata  --rm -it -p 8888:8888 rapidsai/rapidsai-dev-nightly:0.16-cuda10.1-devel-ubuntu18.04-py3.7 bash

# inside the container
cd cuml/python
python setup.py install

ls -ltrd /opt/conda/envs/rapids/lib/python3.7/site-packages/cuml* 

Expected behavior
Install the library without version suffix.

@tfeher tfeher added bug Something isn't working ? - Needs Triage Need team to review and classify labels Sep 22, 2020
@wphicks
Copy link
Contributor

wphicks commented Sep 24, 2020

@tfeher, you said this was a recent change? As far as I can tell, this is the same behavior in 0.15 and 0.16, but I may be misunderstanding the issue.

Output in 0.15:

(rapids) root@8b29f60efdfc:/rapids/cuml/python# ls -ltrd /opt/conda/envs/rapids/lib/python3.7/site-packages/cuml*
drwxrwxrwx 29 root root 4096 Aug 26 09:08 /opt/conda/envs/rapids/lib/python3.7/site-packages/cuml
drwxrwxrwx  2 root root 4096 Aug 26 09:08 /opt/conda/envs/rapids/lib/python3.7/site-packages/cuml-0+untagged.1.g918df35-py3.7.egg-info
drwxr-xr-x  4 root root 4096 Sep 24 16:31 /opt/conda/envs/rapids/lib/python3.7/site-packages/cuml-0+untagged.1.g918df35-py3.7-linux-x86_64.egg

Output in 0.16:

rapids@76d2e7cf1dad:/rapids/cuml/python$ ls -ltrd /opt/conda/envs/rapids/lib/python3.7/site-packages/cuml* 
drwxrwxrwx  2 root   root   4096 Sep 24 09:43 /opt/conda/envs/rapids/lib/python3.7/site-packages/cuml-0+untagged.1.gce14638-py3.7.egg-info
drwxrwxrwx 28 root   root   4096 Sep 24 09:43 /opt/conda/envs/rapids/lib/python3.7/site-packages/cuml
drwxr-xr-x  4 rapids rapids 4096 Sep 24 16:33 /opt/conda/envs/rapids/lib/python3.7/site-packages/cuml-0+untagged.1.gce14638-py3.7-linux-x86_64.egg

I'm sure I'm probably missing something here; can you point out what I'm not seeing? Or maybe this was a pre-0.15 change?

@tfeher
Copy link
Contributor Author

tfeher commented Sep 24, 2020

@wphicks thanks for looking into this. I must be wrong while thinking that it was a recent change. I have also checked with older containers and I confirm what you have found: even with 0.14 stable we have the same behavior that I report here. (Also tried checking out branch-0.15 and installing it in 0.15 container, with the same result). So please ignore the "recently" word.

Otherwise, the issue remain the same: I expect that after running python setup.py install, an import cuml statement would import the just installed package, which is not the case.

@wphicks
Copy link
Contributor

wphicks commented Sep 24, 2020

Ah great! Thanks for tracking it back even further. I'll remove the "needs triage" label; this is definitely worth looking into further.

@wphicks wphicks removed the ? - Needs Triage Need team to review and classify label Sep 24, 2020
@github-actions
Copy link

This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@tfeher
Copy link
Contributor Author

tfeher commented Feb 18, 2021

The issue still exist in the recent dev containers.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working inactive-90d
Projects
None yet
Development

No branches or pull requests

2 participants