Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add haversine metric to cuml.neighbors.NearestNeighbors #3143

Closed
miguelusque opened this issue Nov 15, 2020 · 4 comments
Closed

[FEA] Add haversine metric to cuml.neighbors.NearestNeighbors #3143

miguelusque opened this issue Nov 15, 2020 · 4 comments
Labels
CUDA / C++ CUDA issue feature request New feature or request New Prim For tracking new prims that will be added to our existing collection

Comments

@miguelusque
Copy link
Member

miguelusque commented Nov 15, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
While porting some code from SKL to cuML, I have noticed that haversine metric is not supported in cuml.neighbors.NearestNeighbors.

Describe the solution you'd like
To have haversine metric available in cuML.

Describe alternatives you've considered
We have try to work around it by converting (latitude, longitude) to (northing, easting) coordinates, and then using Euclidean metric . Nevertheless, there are well-known precision issues with that conversion when the distance is lower than 3 meters, if I recall correctly.

Additional context
Add any other context, code examples, or references to existing implementations about the feature request here.
@miguelusque miguelusque added ? - Needs Triage Need team to review and classify feature request New feature or request labels Nov 15, 2020
@datametrician
Copy link

@JohnZed is this possible for 0.17?

@Nanthini10 Nanthini10 removed the ? - Needs Triage Need team to review and classify label Nov 18, 2020
@cjnolet cjnolet added CUDA / C++ CUDA issue New Prim For tracking new prims that will be added to our existing collection labels Nov 30, 2020
@miguelusque miguelusque changed the title [FEA] Add harvesine metric to cuml.neighbors.NearestNeighbors [FEA] Add haversine metric to cuml.neighbors.NearestNeighbors Dec 24, 2020
@miguelusque
Copy link
Member Author

Hi!

I have just noticed that haversine distance is now available in cuSpatial.

Is there any chance it might be reused that code to implement haversine distance in cuML?

Thanks! And Merry Xmas!

Regards,
Miguel

@JohnZed
Copy link
Contributor

JohnZed commented Feb 16, 2021

The sklearn approach takes lat/lon in and out:
https://scikit-learn.org/stable/modules/generated/sklearn.metrics.pairwise.haversine_distances.html

@JohnZed
Copy link
Contributor

JohnZed commented Mar 17, 2021

Closed by #3579

@JohnZed JohnZed closed this as completed Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CUDA / C++ CUDA issue feature request New feature or request New Prim For tracking new prims that will be added to our existing collection
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@JohnZed @cjnolet @datametrician @Nanthini10 @miguelusque