[FEA] Modernize CMake Build Structure #3375
Labels
Build or Dep
Issues related to building the code or dependencies
CMake
feature request
New feature or request
inactive-30d
inactive-90d
Tech Debt
Issues related to debt
Discovered in PR #3367, our CMake build architecture could benefit from moving to a more modern design using targets instead of the current implementation. This is a blocker for migrating to scikit-build. A non-complete list of improvements to make:
CMAKE_CXX_FLAGS
andCMAKE_CUDA_FLAGS
target_include_directories
andtarget_link_libraries
$<$<BOOL:BUILD_CUML_MPI_COMMS>:${MPI_CXX_INCLUDE_PATH}>
find_package(CUML)
A first pass was done for the linked PR and can be seen here: https://github.com/rapidsai/cuml/blob/6c2ebde695508ebdcab9ea641719d96f2775849b/cpp/CMakeLists.txt (Very much a WIP)
The text was updated successfully, but these errors were encountered: