Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] quantile computation in RF is not correct #3529

Closed
teju85 opened this issue Feb 19, 2021 · 2 comments
Closed

[BUG] quantile computation in RF is not correct #3529

teju85 opened this issue Feb 19, 2021 · 2 comments
Labels
bug Something isn't working CUDA / C++ CUDA issue inactive-30d

Comments

@teju85
Copy link
Member

teju85 commented Feb 19, 2021

preprocess_quantile in RF does not correctly compute the bin ID's and their thresholds. For eg: in the current implementation, there's always the chance of missing out on those elements which fall in the last bin, especially when n_bins does not evenly divide the n_rows.

Tagging @vinaydes who has a fix for this and will be filing a PR soon.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@teju85
Copy link
Member Author

teju85 commented Mar 29, 2021

The above PR has already solved this issue. Closing.

@teju85 teju85 closed this as completed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CUDA / C++ CUDA issue inactive-30d
Projects
None yet
Development

No branches or pull requests

1 participant