[BUG] cannot use local RAFT in get_raft.cmake for building cuML this support is broken

[mdoijade]

Describe the bug
I am adding this set(CPM_raft_SOURCE "/data/devtech_compute/raft") in get_raft.cmake as per the comment in it but it fails in cmake configure with error below.

• Configuring done
  CMake Error at CMakeLists.txt:356 (add_library):
  Target "cuml" links to target "raft::raft" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?
  CMake Error at CMakeLists.txt:211 (add_library):
  Target "cuml++" links to target "raft::raft" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?
  CMake Error at test/CMakeLists.txt:149 (add_executable):
  Target "prims" links to target "raft::raft" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?
  CMake Error at test/CMakeLists.txt:149 (add_executable):
  Target "prims" links to target "raft::raft" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?

Steps/Code to reproduce bug
set(CPM_raft_SOURCE "/path/to/your_raft") in get_raft.cmake and perform cmake as below
cmake -DCMAKE_INSTALL_PREFIX=. -DCMAKE_CUDA_ARCHITECTURES=NATIVE ../cpp

Expected behavior
cmake should enable using RAFT from given local dir

Environment details (please complete the following information):

• Environment location: [Bare-metal, Docker, Cloud(specify cloud provider)] - All
• Linux Distro/Architecture: [Ubuntu 16.04 amd64] - All
• GPU Model/Driver: [V100 and driver 396.44]
• CUDA: [11.0 - 11.2]
• Method of cuDF & cuML install: [from source] -

Additional context
Add any other context about the problem here.

[mdoijade]

@dantegd @teju85 for visibility.

[trxcllnt]

@mdoijade CPM should be doing this for you, but as a work around you can configure your local copy of RAFT then use its build dir as the raft_ROOT:

cmake -S /data/devtech_compute/raft/cpp \
      -B /data/devtech_compute/raft/cpp/build

cmake -S /data/devtech_compute/cuml/cpp \
      -B /data/devtech_compute/cuml/cpp/build \
      -D raft_ROOT=/data/devtech_compute/raft/cpp/build

[trxcllnt]

@mdoijade looking at it again, I think your path to the RAFT source is wrong. It should be the path to the cpp dir like this:

cmake -S /data/devtech_compute/cuml/cpp \
      -B /data/devtech_compute/cuml/cpp/build \
      -D CPM_raft_SOURCE=/data/devtech_compute/raft/cpp

[mdoijade]

@trxcllnt I am getting same error as reported in description with "-D CPM_raft_SOURCE=/data/devtech_compute/raft/cpp".
I figured a temporary way to let cuML use my local raft, by setting FETCHCONTENT_SOURCE_DIR_RAFT:PATH in CMakeCache.txt

[dantegd]

@mdoijade I'm having trouble reproducing the issue when using the CMake variable and the path to RAFT's cpp folder as Paul suggested, for example:

(ns0621) ➜  build git:(branch-21.08) ✗ pwd
/home/galahad/RAPIDS/21.08/cuml/fix-raftpath/cpp/build
(ns0621) ➜  build git:(branch-21.08) ✗ cmake .. -DCMAKE_CUDA_ARCHITECTURES="NATIVE" -DCPM_raft_SOURCE=/home/galahad/RAPIDS/21.08/cuml/raft/cpp
-- The CXX compiler identification is GNU 9.3.0
-- The CUDA compiler identification is NVIDIA 11.2.152
...

-- CPM: adding package raft@ (/home/galahad/RAPIDS/21.08/cuml/raft/cpp)
-- RAFT: No CMAKE_INSTALL_PREFIX argument detected, setting to: /home/galahad/miniconda3/envs/ns0621
-- Found OpenMP_CXX: -fopenmp (found version "4.5")
...

-- Generating done
-- Build files have been written to: /home/galahad/RAPIDS/21.08/cuml/fix-raftpath/cpp/build

can you try using the variable from the command line like the above, clearing the build folder (to be sure) as opposed to using set to see if this still happens?

[mdoijade]

@dantegd using the "-DCPM_raft_SOURCE=/home/galahad/RAPIDS/21.08/cuml/raft/cpp" is working now for me.
I don't recall why it hadn't worked with @trxcllnt had suggested the same.

[github-actions]

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.