Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Fix issue with Polygon.contains(LineString) #1185

Closed
thomcom opened this issue Jun 7, 2023 · 0 comments · Fixed by #1186
Closed

[BUG]: Fix issue with Polygon.contains(LineString) #1185

thomcom opened this issue Jun 7, 2023 · 0 comments · Fixed by #1186
Assignees
Labels
bug Something isn't working

Comments

@thomcom
Copy link
Contributor

thomcom commented Jun 7, 2023

Version

23.06

On which installation method(s) does this occur?

Docker, Conda, Source, Rapids-Compose

Describe the issue

The method I'm using to solve for the case when a LineString shares boundary points with a Polygon, intersects it, and has no interior points in the Polygon, is incorrect. I have a PR for this coming right up.

--x--
| | |
| | |
| | |
--x--

Minimum reproducible example

rhs = cuspatial.GeoSeries([LineString([(0.5, 0.0), (0.5, 1.0)])])
lhs = cuspatial.GeoSeries([Polygon([(0, 0), (0, 1), (0.3, 0.4), (1, 1), (1, 0)])])
print('cuSpatial', lhs.contains(rhs))
print('geopandas', lhs.to_geopandas().contains(rhs.to_geopandas()))

Relevant log output

cuSpatial 0    True
dtype: bool
geopandas 0    False
dtype: bool

Environment details

No response

Other/Misc.

No response

@thomcom thomcom added the bug Something isn't working label Jun 7, 2023
@github-project-automation github-project-automation bot moved this to Todo in cuSpatial Jun 7, 2023
@thomcom thomcom self-assigned this Jun 7, 2023
@thomcom thomcom moved this from Todo to In Progress in cuSpatial Jun 20, 2023
@thomcom thomcom moved this from In Progress to Review in cuSpatial Jun 20, 2023
@rapids-bot rapids-bot bot closed this as completed in #1186 Aug 2, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in cuSpatial Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant