Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: GeoSeries tests use invalid data and rely on hard-coded data matching #1471

Closed
harrism opened this issue Oct 10, 2024 · 0 comments · Fixed by #1472
Closed

[BUG]: GeoSeries tests use invalid data and rely on hard-coded data matching #1471

harrism opened this issue Oct 10, 2024 · 0 comments · Fixed by #1472
Assignees
Labels
bug Something isn't working Python Related to Python code tests Relating to tests and test automation

Comments

@harrism
Copy link
Member

harrism commented Oct 10, 2024

Version

24.12

On which installation method(s) does this occur?

Docker, Conda, Source, Rapids-Compose

Describe the issue

The fixture data (gs and polys in conftest.py) includes invalid polygons. This should be fixed. Also, some of the tests compare against hard-coded values from the fixture data. This is brittle and should be fixed.

Some tests were xfailed in #1467

Minimum reproducible example

No response

Relevant log output

No response

Environment details

No response

Other/Misc.

No response

@harrism harrism added bug Something isn't working Python Related to Python code tests Relating to tests and test automation labels Oct 10, 2024
@harrism harrism self-assigned this Oct 10, 2024
@rapids-bot rapids-bot bot closed this as completed in 1bf2527 Oct 17, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in cuSpatial Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Python Related to Python code tests Relating to tests and test automation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant