Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC/QST] Scale parameter in quadtree methods #397

Closed
buckeye17 opened this issue May 6, 2021 · 9 comments · Fixed by #797
Closed

[DOC/QST] Scale parameter in quadtree methods #397

buckeye17 opened this issue May 6, 2021 · 9 comments · Fixed by #797
Assignees
Labels
doc Documentation question Further information is requested

Comments

@buckeye17
Copy link

The API documentation describes the scale parameter as, "Scale to apply to each point’s distance from (x_min, y_min)." While this is comprehensible, I'm struggling to understand why someone would want to change it. Is it so that the location data can be kept in coordinate reference frame, while outputs for trajectories, etc. can be given in another? I've looked over the demos and examples and can't find any explanation for why this feature is useful, and I'm not sure how it affects the quadtree results, if at all. Thanks for any clarification you can provide!

@buckeye17 buckeye17 added Needs Triage Need team to review and classify question Further information is requested labels May 6, 2021
@zhangjianting
Copy link
Contributor

quadtrees work on a discrete space. scale, together with x_min and y_min, defines the configuration of the grid that a quadtree works on. The smaller the scale, the more rows/columns of the grid and typically the larger and the deeper of the resulting quadtree. That being said, the tradeoff between filtering and refinement (for spatial join and other query types) when utilizing quadtree indexing does not have a definite relationship with scale (or grid resolution).
Ideally, a "smarter" indexing technique can determine scale automatically but it is still pretty much an open research question. As such, cuspatial allows users to specify scale for better control. It is understandable that some background expertise is needed. Hopefully the slides at following link can provide some additional info https://github.com/zhangjianting/cuspatial/blob/fea-spatial-join/docs/quadtree_indexing_spatial_join.pdf

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@harrism harrism added doc Documentation and removed Needs Triage Need team to review and classify inactive-90d labels Aug 2, 2022
@harrism
Copy link
Member

harrism commented Aug 2, 2022

We should add more of an explanation as provided by @zhangjianting to the documentation for this function.

@harrism harrism moved this to Todo in cuSpatial Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@harrism
Copy link
Member

harrism commented Sep 5, 2022

@trxcllnt can you add the explanation as part of your refactoring?

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@harrism harrism changed the title [QST] Scale parameter in quadtree methods [DOC/QST] Scale parameter in quadtree methods Oct 5, 2022
@harrism
Copy link
Member

harrism commented Oct 24, 2022

We need to update the documentation here:

Scale to apply to each point's distance from ``(x_min, y_min)``

We should also provide default values for scale, max_depth.

Also the Python API for min_size needs to be updated to match max_size in the C++ API.

Discussion:

  • Scale is not a great name, since we divide by it. Almost a normalization factor?

@harrism
Copy link
Member

harrism commented Nov 21, 2022

@trxcllnt can we also consider this issue fixed by #797 ?

@rapids-bot rapids-bot bot closed this as completed in #797 Nov 22, 2022
@rapids-bot rapids-bot bot closed this as completed in da7d3a4 Nov 22, 2022
Repository owner moved this from In Progress to Done in cuSpatial Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation question Further information is requested
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants