Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: .contains_properly has at least 350ms of overhead #892

Open
thomcom opened this issue Feb 2, 2023 · 0 comments
Open

[BUG]: .contains_properly has at least 350ms of overhead #892

thomcom opened this issue Feb 2, 2023 · 0 comments
Labels
bug Something isn't working Needs Triage Need team to review and classify

Comments

@thomcom
Copy link
Contributor

thomcom commented Feb 2, 2023

Version

23.04

On which installation method(s) does this occur?

Rapids-Compose

Describe the issue

.contains_properly currently takes about 550ms to run. I profiled it and saw that 250ms of that time is in the align_to_index call, which is potentially optional, especially if our API can deviate from GeoPandas in improved usability. I also saw that 150ms of the runtime is spent checking the three feature type exclusion requests, is_only_points, is_only_linestrings, or is_only_polygons. These should probably be optimized.

Minimum reproducible example

No response

Relevant log output

No response

Environment details

rapids-compose 23.04

Other/Misc.

No response

@thomcom thomcom added bug Something isn't working Needs Triage Need team to review and classify labels Feb 2, 2023
@jarmak-nv jarmak-nv moved this to Todo in cuSpatial Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs Triage Need team to review and classify
Projects
Status: Todo
Development

No branches or pull requests

1 participant