Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Refactor charts code to Holoviews #465

Closed
AjayThorve opened this issue Apr 5, 2023 · 2 comments
Closed

[FEA] Refactor charts code to Holoviews #465

AjayThorve opened this issue Apr 5, 2023 · 2 comments
Assignees
@AjayThorve
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@AjayThorve
Copy link
Member

AjayThorve commented Apr 5, 2023 •
edited
Loading

  • Refactor charts code to reuse already implemented modules in holoviews and panel. One example is bokeh charts can be simplified to use cuDF directly, since holoviews supports generating bokeh bar charts, while taking cuDF dataframe as input.

cc @exactlyallan
@AjayThorve AjayThorve added feature request New feature or request ? - Needs Triage Need team to review and classify labels Apr 5, 2023
@AjayThorve
Copy link
Member Author

AjayThorve commented May 8, 2023 •
edited
Loading

  • Support aggregate chart query without datatiles
  • Add an input parameter to disable datatiles (default is on) -> edit: Removed datatiles support
  • replace bokeh bar charts with holoviews implemention, and fix query errors with datatiles
  • add a list of aggregate methods for groupby supporting datatiles, and turn off datatiles for the rest
  • add unit tests for the new chart implementations

@exactlyallan exactlyallan changed the title [FEA] Refactor charts code [FEA] Refactor charts code to Holoviews May 10, 2023
@AjayThorve
Copy link
Member Author

Ths is now implemented in #494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AjayThorve AjayThorve

Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
cuxfilter
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AjayThorve