Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XArray in Dask-CUDA CI #344

Closed
quasiben opened this issue Jul 10, 2020 · 8 comments
Closed

XArray in Dask-CUDA CI #344

quasiben opened this issue Jul 10, 2020 · 8 comments
Labels
feature request New feature or request

Comments

@quasiben
Copy link
Member

@jacobtomlinson has been exploring adding more GPU functionality with xarray and in PR pydata/xarray#4214 he has added initial CuPy tests. I'd like to ask if dask-cuda can support this effort by running xarray GPU tests in the CI similar to how we test distributed -- I do not expect this tests to be overly onerous and lengthy.

@pentschev
Copy link
Member

pentschev commented Jul 10, 2020

@jacobtomlinson and I have briefly chatted earlier today and we'll work on having tests run nightly on our DGXs, just as we do for multi-GPU tests for dask-cuda and UCX-Py. Jacob suggested as well that we report failures automatically to GH in the form of issues, and to prevent many false positives we might come up with a secondary repo just for the automated reporting, which will give us a chance to parse them and file appropriate issues for the appropriate project.

@pentschev
Copy link
Member

For broader visibility, NEP-35 should be part of NumPy 1.20, which will allow us to unblock parts of this.

@pentschev pentschev added the feature request New feature or request label Jan 8, 2021
@github-actions
Copy link

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

@jakirkham
Copy link
Member

NumPy 1.20 is out. Though guessing we still need fixes to Dask

@pentschev
Copy link
Member

We have some xarray tests running nightly and being reported in pentschev/ucx-py-ci#5 . We could extend those eventually though.

@jakirkham
Copy link
Member

Gotcha. Thanks Peter! So in that case, maybe we should close and open new issues for any additional needed tests. WDYT?

@pentschev
Copy link
Member

I'm fine either way, but I don't know now what are the additional needed tests. 🙂

@jakirkham
Copy link
Member

In that case, let's close. We have some testing. If we need more, we can add them to the repo you've already setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants