Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Custom index type of mdspan. #498

Closed
trivialfis opened this issue Feb 9, 2022 · 2 comments
Closed

[FEA] Custom index type of mdspan. #498

trivialfis opened this issue Feb 9, 2022 · 2 comments

Comments

@trivialfis
Copy link
Member

The upstream version of mdspan from #437 uses size_t for indexing the memory buffer. While size_t is a good choice for many cases as it can prevent integer overflow errors, it also increases register pressure and might have performance overhead. We can opt to use other smaller indexing types by removing the conversion as done in trivialfis/mdspan@f18e694 .

@trivialfis trivialfis added the feature request New feature or request label Feb 9, 2022
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants