Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Create actual Distance types that can be paired w/ any optional arguments #852

Open
Tracked by #1451
cjnolet opened this issue Sep 27, 2022 · 0 comments
Open
Tracked by #1451
Labels
feature request New feature or request

Comments

@cjnolet
Copy link
Member

cjnolet commented Sep 27, 2022

Our current distances API uses a simple enum (see raft/distance/distance_types.hpp). The general design of accepting the enum along with an optional metric_arg argument follows the Scipy and Scikit-learn APIs, but as @mhoemmen points out, it could be made a little more C++-friendly by accepting an actual type for the distances which can be paired w/ any metric_arg options they might support. The enum + metric_arg is used in several places in RAFT and so I think it warrants a larger discussion on how we should redesign this API (if at all) so that we can update it across RAFT and its consuming libraries all at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant