Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Possibly add a prefetch resource adaptor #1590

Closed
harrism opened this issue Jun 25, 2024 · 1 comment
Closed

[FEA] Possibly add a prefetch resource adaptor #1590

harrism opened this issue Jun 25, 2024 · 1 comment
Labels
? - Needs Triage Need team to review and classify cpp Pertains to C++ code feature request New feature or request Python Related to RMM Python API

Comments

@harrism
Copy link
Member

harrism commented Jun 25, 2024

Is your feature request related to a problem? Please describe.
In experiments we are seeing value to prefetch-on-allocate for reducing page faults on initial write of an allocation. This is especially important in undersubscribed workloads where the entire pool could be prefetched when it is first allocated and when it grows.

Describe the solution you'd like
Add an adaptor that calls cudaMemPrefetchAsync on each allocation.

Describe alternatives you've considered
We have implemented this using the Python CallbackMemoryResource, but it may be beneficial to have it in C++.

Additional context
Add any other context, code examples, or references to existing implementations about the feature request here.

@harrism harrism added feature request New feature or request Python Related to RMM Python API ? - Needs Triage Need team to review and classify cpp Pertains to C++ code labels Jun 25, 2024
@harrism harrism mentioned this issue Jul 22, 2024
3 tasks
@harrism
Copy link
Member Author

harrism commented Jul 22, 2024

Fixed by #1608

@harrism harrism closed this as completed Jul 22, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in RMM Project Board Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify cpp Pertains to C++ code feature request New feature or request Python Related to RMM Python API
Projects
Status: Done
Development

No branches or pull requests

1 participant