Add OOM fail reason, attempted allocation size to exception messages #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
harrism
requested changes
Feb 18, 2025
wence-
requested changes
Feb 18, 2025
|
Note that this PR needs labels/etc. but I don't have permissions to add them. |
abellina
approved these changes
Feb 21, 2025
bdice
reviewed
Feb 24, 2025
| return block; | ||
| } catch (std::exception const& e) { | ||
| if (try_size <= min_size) { | ||
| RMM_LOG_ERROR("[A][Stream %s][Upstream %zuB][FAILURE maximum pool size exceeded: %s]", |
There was a problem hiding this comment.
(non-blocking) What does the [A] mean here? This may be a historical question for @harrism.
bdice
approved these changes
Feb 24, 2025
|
@wence-, you requested changes -- could you provide feedback? |
bdice
reviewed
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues:
try_to_expand(). It also does a more thorough job of forwarding on failure details in other locations. A test has been added to test this case explicitly.Notes:
EXPECT_THROW()macros already in the tests, and one more test was explicitly added.try_to_expand()inpool_memory_resource.hppattempts to allocate for the case wheretry_sizeis less thanmin_size, whereas before it just immediately errored. If this isn't the behavior we want I can change it. Previously it was just erroring that we didn't have enough memory, which isn't right either.Checklist