Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Create device_memory_resource to wrap CUB caching allocator #290

Closed
jrhemstad opened this issue Feb 14, 2020 · 2 comments
Closed

[FEA] Create device_memory_resource to wrap CUB caching allocator #290

jrhemstad opened this issue Feb 14, 2020 · 2 comments
Labels
feature request New feature or request

Comments

@jrhemstad
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Similar to #276, it would be straightforward and interesting to add a device_memory_resource that wraps CUB's caching allocator.

Describe the solution you'd like

Create cub_memory_resource to wrap cub::CachingDeviceAllocator.
@jrhemstad jrhemstad added the feature request New feature or request label Feb 14, 2020
@jrhemstad jrhemstad mentioned this issue Feb 14, 2020
Closed
@hcho3 hcho3 mentioned this issue Jul 6, 2020
Closed
@jrhemstad jrhemstad mentioned this issue Jul 6, 2020
Closed
@harrism
Copy link
Member

harrism commented Aug 4, 2020

@jrhemstad can/should this be closed?

@jrhemstad
Copy link
Contributor Author

Closing. No longer needed. dmlc/xgboost#5861 (comment) showed that the CUB caching allocator is much slower than the pool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] CUB memory resource jrhemstad/rmm
[WIP] CUB memory resource jrhemstad/rmm
2 participants
@harrism @jrhemstad