Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other (optional?) dependencies #212

Open
jakirkham opened this issue Aug 24, 2024 · 0 comments
Open

Other (optional?) dependencies #212

jakirkham opened this issue Aug 24, 2024 · 0 comments

Comments

@jakirkham
Copy link
Member

After noticing a few missing dependencies ( #210 ) & ( #211 ), ran depfinder on wholegraph and got the following output:

{
    "builtin": [
        "argparse",
        "importlib",
        "multiprocessing",
        "os",
        "pickle",
        "random",
        "typing"
    ],
    "questionable": [
        "dgl",
        "mpi4py",
        "torch",
        "torch_geometric",
        "torch_sparse",
        "wg_torch"
    ],
    "relative": [
        "comm",
        "common_options",
        "cugraphops",
        "data_loader",
        "distributed_launch",
        "dlpack_utils",
        "embedding",
        "gnn_model",
        "graph_ops",
        "graph_structure",
        "initialize",
        "tensor",
        "utils",
        "wholegraph_env"
    ],
    "required": [
        "numpy",
        "packaging",
        "pylibcugraphops",
        "pylibwholegraph",
        "torch"
    ]
}

The builtins we can ignore. The relatives will ignore for the moment

With required, a couple of these are covered elsewhere:

Though we should consider adding packaging and pylibcugraphops

The questionable list would be good to hear feedback from the Wholegraph team on. Maybe these are optional dependencies and we can define them under extras. If some are hard requirements, that would be good to know as that would change how these are handled

Anyways please let us know what you think on how these should be handled 🙂

@jakirkham jakirkham changed the title Other (optional?) dependencies? Other (optional?) dependencies Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant