Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEEDBACK] Core: distinct_count aggr. #95

Open
AlmogBaku opened this issue Jul 25, 2022 · 2 comments
Open

[FEEDBACK] Core: distinct_count aggr. #95

AlmogBaku opened this issue Jul 25, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request provider/aws Related to the AWS provider provider/redis Related to the Redis provider provider/snowflake Related to the Snowflake provider roadmap This issue is part of the roadmap

Comments

@AlmogBaku
Copy link
Member

Background

I should be able to aggregate (rolling window) the count over unique only values - this should be similar the the LabSDK functionality

What do you propose to do?

Implement `distinct_countz aggregation on the Core.

Algorithm: having a unique set per bucket.

[A] Redis implementation:

  1. Either having a set for this kind of purpose
  2. Or having a Lua function that stores sets in the HSET

I think (1) makes more sense

[B] Store on snowflake/s3

[C] Add this functionality to the SQL builder

What have you already tried?

No response

What else should we know?

No response
@AlmogBaku AlmogBaku added enhancement New feature or request provider/snowflake Related to the Snowflake provider provider/redis Related to the Redis provider documentation Improvements or additions to documentation provider/aws Related to the AWS provider labels Jul 25, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale This issue is stale label Sep 24, 2022
@AlmogBaku AlmogBaku removed the stale This issue is stale label Sep 24, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale This issue is stale label Nov 24, 2022
@github-actions github-actions bot closed this as completed Dec 9, 2022
@AlmogBaku AlmogBaku reopened this Dec 19, 2022
@AlmogBaku AlmogBaku removed the stale This issue is stale label Dec 19, 2022
@AlmogBaku AlmogBaku added the roadmap This issue is part of the roadmap label Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request provider/aws Related to the AWS provider provider/redis Related to the Redis provider provider/snowflake Related to the Snowflake provider roadmap This issue is part of the roadmap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlmogBaku