Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamFromSignal with onlyChanges = False may filter out initial value #124

Open
raquo opened this issue Jun 26, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@raquo
Copy link
Owner

raquo commented Jun 26, 2024

onlyChanges = False option is not used by Airstream itself, and is not directly exposed in Airstream's intended public API, but still, it was intended as an escape hatch, and should work.

Discussion in discord

See failing test case in streamfromsignal-fix branch

I think the solution is something along the lines of adding "if isFirstPull and !changesOnly, then run that same transaction" to def onStart in class StreamFromSignal, but I would need to do a more thorough review to confirm.

@raquo raquo added the bug Something isn't working label Jun 26, 2024
@raquo raquo changed the title StreamForSignal with onlyChanges = False may filter out initial value StreamFromSignal with onlyChanges = False may filter out initial value Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant