Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk.nft.transfer does not work backend using ETHERS package #350

Open
vicwtang opened this issue May 13, 2022 · 1 comment
Open

sdk.nft.transfer does not work backend using ETHERS package #350

vicwtang opened this issue May 13, 2022 · 1 comment
Labels
bug Something isn't working Tier 3 - in progress Tier three question: ETA for fix is 4-7 business days (requires contract changes / bug fix)

Comments

@vicwtang
Copy link

Lower priority issue as this can be resolved by using the Web3 package instead of ethers.

currently, attempting to call sdk.nft.transfer when the wallet is created with ETHERS package fails

    const transfer = await sdk.nft.transfer({ itemId })
    console.log('transer() returned ', { transfer })
    const tx = await transfer.submit({ to: recipient })
    await tx.wait()

due to there being 2 function signatures for safeTransferFrom, rarible sdk with ethers is unable to select the current safeTransferFrom function to execute

this issue is solved if I switch to using the Web3 package instead of ethers. However, this SHOULD work in ethers.

@eduardstal eduardstal self-assigned this May 24, 2022
@eduardstal eduardstal added bug Something isn't working Tier 3 - in progress Tier three question: ETA for fix is 4-7 business days (requires contract changes / bug fix) labels May 24, 2022
@eduardstal eduardstal removed their assignment Jul 1, 2022
@evgenynacu
Copy link
Member

Hi @vicwtang
Sorry for late reply

Is it still an issue for you?
Let me know if you need some help here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Tier 3 - in progress Tier three question: ETA for fix is 4-7 business days (requires contract changes / bug fix)
Projects
None yet
Development

No branches or pull requests

3 participants