OSS-668: Rasa Knowledge base actions are unable to query about a certain attribute of an object unless the user first asks to obtain a list of objects of a specific type. #922

Thirunayan22 · 2023-01-10T09:14:50Z

Proposed changes:

The improvement requires changes to the classes ActionQueryKnowledgeBase and InMemoryKnowledgeBase under rasa-sdk.
The object_type can be inferred by utilizing the entity classification (DIET) where object types are used as entities to annotate object names.
This also requires changes to be made to slot management to enable dynamic inference of object_type.
E.g: If the user asks ‘price range of Berlin Burrito Company’, then rasa will extract and set attribute slot value to ‘price-range’ and hotel slot value to ‘Berlin Burrito Company’. From this it can be inferred that the user is talking about object type ‘hotel’.

Status (please check what you already did):

made PR ready for code review
added some tests for the functionality
updated the documentation in the rasaHQ/rasa
updated the changelog (please check changelog for instructions)
reformat files using black (please check Readme for instructions)

…ttribute functions

CLAassistant · 2023-01-10T09:15:00Z

All committers have signed the CLA.

Pulling updates from RasaHQ/rasa-sdk main branch to rootcodelabs/rasa-sdk OSS-668 branch

ancalita

Many thanks for your contribution 💯
I have left some suggestions and questions about implementation choices in this PR. Please troubleshoot the failing unit tests as can be seen in the CI runs (for example 3.10 job run) and also add unit tests for the functionality you've added. You can run the tests locally too through your IDE or running make test in a venv where you've installed rasa-sdk.

changelog/668.bugfix.md

rasa_sdk/knowledge_base/utils.py

rasa_sdk/knowledge_base/actions.py

Gajithra · 2023-02-02T17:51:33Z

Thanks @ancalita for the feedback! We will work on it to make the changes.

Pulling updates from RasaHQ/rasa-sdk main to rootcodelabs/rasa-sdk OSS-668

…the contribution changes

…ction name

RAOC-5: added comprehensive typing hint

RAOC-10: Uncommented code snippet that was previously commented

…suggested in PR review

…eview

OSS-668-PR-CHANGES: Made requested changes in PR Review#3

Gajithra · 2023-05-22T12:10:11Z

Thank you for your patience throughout this reviewing process and for addressing all my questions and comments 💯 ! I left some fresh comments, I will proceed to reviewing the docs PR now and I will also test with the public repo you provided. In the interest of time, I first shared these initial comments and I will follow-up if I have any other comments after manual testing.

Thanks for sharing your initial comments @ancalita 🙌🏽 . We have addressed the requested changes here and in the docs PR in rasa repo.

Pulling updates from RasaHQ/rasa-sdk main to rootcodelabs/rasa-sdk OSS-668

ancalita

Looks good 💯 ! Very close to getting merged as well as soon as the last few comments on the unit test are addressed 👍🏻

tests/knowledge_base/test_actions.py

Pulling updates from OSS-668 to OSS-668-PR-CHANGES

…eck inside actual event list

Incorporated Changes Suggested in PR Review #4

Pulling updates from OSS-668 to OSS-668-PR-CHANGES

Re: Added comments in tracker event assertion code block

Gajithra · 2023-06-05T12:35:56Z

Looks good 💯 ! Very close to getting merged as well as soon as the last few comments on the unit test are addressed 👍🏻

Great to hear that @ancalita 🤞🏽! We have addressed your comments and made the requested changes.

ancalita

Nice one 🎉 Thank you for all your hard work 🥇

sonam-pankaj95 · 2023-06-13T10:42:59Z

Congratulations @Gajithra and @Thirunayan22 🎉, would love to see you in contributor's program as well. Thank you @ancalita for leading this 💜

Sorry this is my official account 👍

sonam-pankaj95 · 2023-06-27T12:07:46Z

Hey @Thirunayan22 and @Gajithra ,

Can you please share your email ids, here or mail them at s.pankaj@rasa.com, So that I can add both of you in our contributor's program and send some swags.

Thanks,
Sonam

Thirunayan22 · 2023-07-27T15:58:22Z

Hi @sonam-pankaj95 , here are our email ids. I have sent the email addresses to you in email too.

Thirunayan: thirunayan.dinesh@rootcode.io
Gajithira: gajithira.puvanendran@rootcode.io

Gajithra added 3 commits January 10, 2023 14:22

modified logic in run, slot management in _query_objects and _query_a…

cd1485f

…ttribute functions

added get_object_types function

751bc1f

added get_object_type_dynamic function

c611f0e

Gajithra and others added 4 commits January 17, 2023 09:00

updated changelog

bfa920c

updated changelog

1b1e4fd

Merge pull request #1 from RasaHQ/main

b600b88

Pulling updates from RasaHQ/rasa-sdk main branch to rootcodelabs/rasa-sdk OSS-668 branch

Merge branch 'main' into OSS-668

348d898

ancalita self-requested a review February 1, 2023 15:56

ancalita requested changes Feb 2, 2023

View reviewed changes

Gajithra and others added 19 commits February 2, 2023 23:23

Merge pull request #4 from RasaHQ/main

d3c4968

Pulling updates from RasaHQ/rasa-sdk main to rootcodelabs/rasa-sdk OSS-668

modified changelog name and content

826803e

uncommented code snippet that was previously commented to experiment …

9cedec0

…the contribution changes

added comprehensive typing hint

ba32581

renamed to

ca2f13b

replaced the 'get_object_type_dynamic' function name with the new fun…

cbb38df

…ction name

replaced the 'get_object_type_dynamic' function name with the new fun…

e5f8d56

…ction name

modified sentences based on PR review comments

0644efb

updated the 'get_object_type_dynamic' with new name

4e4e24b

Merge pull request #7 from rootcodelabs/RAOC-5

ea37728

RAOC-5: added comprehensive typing hint

Merge pull request #6 from rootcodelabs/RAOC-10

47163e8

RAOC-10: Uncommented code snippet that was previously commented

directly return entity without assigning it to an unused variable as …

34dea76

…suggested in PR review

modified line 184 to safeguard against KeyErrors as suggested in PR r…

22d7098

…eview

added suggestion to code change in line 185 as mentioned in the PR

a77350b

added suggestion to code change in line 185 as mentioned in the PR

7e6352c

modified after running grammerly

1658e99

Added TrackerKnowledgeBase class in tracker.py to set object type slot

85b022b

modified class name

ac01e97

removed passing object_type value as an argument in functions

f781e24

Gajithra and others added 12 commits May 18, 2023 10:11

removed import logging

7bacf54

added print statements for testing

afa3b48

resolved python mutable issue

ff1a1c4

removed print statements and cleaned the code

acfe716

removed import copy

0527396

removed trailing white space in line 157

7d7a4e8

removed trailing white space in line 157

6442349

added spaces between code lines

118b4be

added spaces between code lines

7e7bda0

added space

f4e88d7

Merge pull request #75 from rootcodelabs/OSS-668-PR-CHANGES

e057fc0

OSS-668-PR-CHANGES: Made requested changes in PR Review#3

Fixed formatting and lint code

e653150

Merge pull request #76 from RasaHQ/main

f8ce8ea

Pulling updates from RasaHQ/rasa-sdk main to rootcodelabs/rasa-sdk OSS-668

ancalita reviewed Jun 5, 2023

View reviewed changes

tests/knowledge_base/test_actions.py Outdated Show resolved Hide resolved

tests/knowledge_base/test_actions.py Outdated Show resolved Hide resolved

tests/knowledge_base/test_actions.py Outdated Show resolved Hide resolved

Gajithra and others added 8 commits June 5, 2023 14:11

Merge pull request #77 from rootcodelabs/OSS-668

1c0bf05

Pulling updates from OSS-668 to OSS-668-PR-CHANGES

made a copy of slots using copy.deepcopy() | modified assertion to ch…

592b90d

…eck inside actual event list

format with black

b1a5489

Merge pull request #79 from rootcodelabs/OSS-668-PR-CHANGES

f9bcdee

Incorporated Changes Suggested in PR Review #4

added comments in tracker event assertion code block

7547763

Merge pull request #81 from rootcodelabs/OSS-668

29adf9c

Pulling updates from OSS-668 to OSS-668-PR-CHANGES

formatted code

f8ac1bf

Merge pull request #80 from rootcodelabs/OSS-668-PR-CHANGES

13a766a

Re: Added comments in tracker event assertion code block

ancalita approved these changes Jun 6, 2023

View reviewed changes

ancalita merged commit 2e32306 into RasaHQ:main Jun 6, 2023

RasaHQ deleted a comment from sp-rasa Jun 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OSS-668: Rasa Knowledge base actions are unable to query about a certain attribute of an object unless the user first asks to obtain a list of objects of a specific type. #922

OSS-668: Rasa Knowledge base actions are unable to query about a certain attribute of an object unless the user first asks to obtain a list of objects of a specific type. #922

Thirunayan22 commented Jan 10, 2023 •

edited

Loading

CLAassistant commented Jan 10, 2023 •

edited

Loading

ancalita left a comment •

edited

Loading

Gajithra commented Feb 2, 2023

Gajithra commented May 22, 2023 •

edited

Loading

ancalita left a comment

Gajithra commented Jun 5, 2023

ancalita left a comment

sonam-pankaj95 commented Jun 13, 2023

sonam-pankaj95 commented Jun 27, 2023

Thirunayan22 commented Jul 27, 2023

OSS-668: Rasa Knowledge base actions are unable to query about a certain attribute of an object unless the user first asks to obtain a list of objects of a specific type. #922

OSS-668: Rasa Knowledge base actions are unable to query about a certain attribute of an object unless the user first asks to obtain a list of objects of a specific type. #922

Conversation

Thirunayan22 commented Jan 10, 2023 • edited Loading

CLAassistant commented Jan 10, 2023 • edited Loading

ancalita left a comment • edited Loading

Choose a reason for hiding this comment

Gajithra commented Feb 2, 2023

Gajithra commented May 22, 2023 • edited Loading

ancalita left a comment

Choose a reason for hiding this comment

Gajithra commented Jun 5, 2023

ancalita left a comment

Choose a reason for hiding this comment

sonam-pankaj95 commented Jun 13, 2023

sonam-pankaj95 commented Jun 27, 2023

Thirunayan22 commented Jul 27, 2023

Thirunayan22 commented Jan 10, 2023 •

edited

Loading

CLAassistant commented Jan 10, 2023 •

edited

Loading

ancalita left a comment •

edited

Loading

Gajithra commented May 22, 2023 •

edited

Loading