Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashify_headline should return 6 for 7+ level headers #4

Closed
svisser opened this issue Jun 10, 2014 · 1 comment
Closed

dashify_headline should return 6 for 7+ level headers #4

svisser opened this issue Jun 10, 2014 · 1 comment

Comments

@svisser
Copy link

svisser commented Jun 10, 2014

As h6 is the highest header level in HTML, Markdown only supports headers up to level 6. That means dashify_headline('####### aaa ###') (note the 7 dashes) should return 6 instead of 7 (and the same applies for higher headers).

It would be good to hear your opinion as the documentation does not state this explicitly. However, I just checked it in my Markdown site and it does indeed turn the above into a h6 element.

@svisser svisser changed the title dashify_headline should not accept 7+ level headers dashify_headline should return 6 for 7+ level headers Jun 10, 2014
@rasbt
Copy link
Owner

rasbt commented Jun 11, 2014

Another good point. I am not 100% convinced to make a change here though, since I am not converting to HTML here. But I implemented it anyway. I think more people would use 7 pounds by accident then there are people who want to nest one level deeper by adding a not supported 7 pounds headline.
And thanks again :)

@rasbt rasbt closed this as completed Jun 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants