Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when part of text in anchor is taken out of anchor tag #4

Open
rayrigam opened this issue Apr 20, 2013 · 0 comments
Open

Problem when part of text in anchor is taken out of anchor tag #4

rayrigam opened this issue Apr 20, 2013 · 0 comments

Comments

@rayrigam
Copy link

I took a quick look at your demo and tried a few different string changes and noticed the following issues:

  1. When taking out text that was inside an anchor tag, the text that was taken out shows up in the compared html inside an anchor tag of its own rather than showing up with no anchor tag. For instance, when going from $html1 = Check <a href="http://google.com">this out</a>. to $html2 = Check <a href="http://google.com">this</a> out.
  2. When putting text that was outside of an anchor into an anchor (the opposite to the above example), the text that is now inside the anchor still shows up outside the anchor in the comparison html.
  3. Any change to the href or other attributes of an anchor is not indicated in any way in the comparison html. The most appropriate behavior would be to show the entire anchor element twice; first, the original anchor element inside a "del" tag, and second, the modified one inside an "ins" tag.
mkalkbrenner referenced this issue in mkalkbrenner/php-htmldiff Mar 3, 2015
Added static properties for the default config variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant