Skip to content

Commit 0c7a3af

Browse files
hkallweitgregkh
authored andcommitted
Revert "net: r8169: Disable multicast filter for RTL8168H and RTL8107E"
commit 6a26310 upstream. This reverts commit efa5f13. I couldn't reproduce the reported issue. What I did, based on a pcap packet log provided by the reporter: - Used same chip version (RTL8168h) - Set MAC address to the one used on the reporters system - Replayed the EAPOL unicast packet that, according to the reporter, was filtered out by the mc filter. The packet was properly received. Therefore the root cause of the reported issue seems to be somewhere else. Disabling mc filtering completely for the most common chip version is a quite big hammer. Therefore revert the change and wait for further analysis results from the reporter. Cc: stable@vger.kernel.org Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a302879 commit 0c7a3af

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/net/ethernet/realtek/r8169_main.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2599,9 +2599,7 @@ static void rtl_set_rx_mode(struct net_device *dev)
25992599
rx_mode &= ~AcceptMulticast;
26002600
} else if (netdev_mc_count(dev) > MC_FILTER_LIMIT ||
26012601
dev->flags & IFF_ALLMULTI ||
2602-
tp->mac_version == RTL_GIGA_MAC_VER_35 ||
2603-
tp->mac_version == RTL_GIGA_MAC_VER_46 ||
2604-
tp->mac_version == RTL_GIGA_MAC_VER_48) {
2602+
tp->mac_version == RTL_GIGA_MAC_VER_35) {
26052603
/* accept all multicasts */
26062604
} else if (netdev_mc_empty(dev)) {
26072605
rx_mode &= ~AcceptMulticast;

0 commit comments

Comments
 (0)