Skip to content

Commit 98b5a0f

Browse files
harini-katakamdavem330
authored andcommitted
net: macb: Add support for jumbo frames
Enable jumbo frame support for Zynq Ultrascale+ MPSoC. Update the NWCFG register and descriptor length masks accordingly. Jumbo max length register should be set according to support in SoC; it is set to 10240 for Zynq Ultrascale+ MPSoC. Signed-off-by: Harini Katakam <harinik@xilinx.com> Reviewed-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 7b61f9c commit 98b5a0f

File tree

2 files changed

+27
-4
lines changed

2 files changed

+27
-4
lines changed

drivers/net/ethernet/cadence/macb.c

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -782,7 +782,7 @@ static int gem_rx(struct macb *bp, int budget)
782782
}
783783
/* now everything is ready for receiving packet */
784784
bp->rx_skbuff[entry] = NULL;
785-
len = MACB_BFEXT(RX_FRMLEN, ctrl);
785+
len = ctrl & bp->rx_frm_len_mask;
786786

787787
netdev_vdbg(bp->dev, "gem_rx %u (len %u)\n", entry, len);
788788

@@ -828,7 +828,7 @@ static int macb_rx_frame(struct macb *bp, unsigned int first_frag,
828828
struct macb_dma_desc *desc;
829829

830830
desc = macb_rx_desc(bp, last_frag);
831-
len = MACB_BFEXT(RX_FRMLEN, desc->ctrl);
831+
len = desc->ctrl & bp->rx_frm_len_mask;
832832

833833
netdev_vdbg(bp->dev, "macb_rx_frame frags %u - %u (len %u)\n",
834834
macb_rx_ring_wrap(first_frag),
@@ -1633,7 +1633,10 @@ static void macb_init_hw(struct macb *bp)
16331633
config |= MACB_BF(RBOF, NET_IP_ALIGN); /* Make eth data aligned */
16341634
config |= MACB_BIT(PAE); /* PAuse Enable */
16351635
config |= MACB_BIT(DRFCS); /* Discard Rx FCS */
1636-
config |= MACB_BIT(BIG); /* Receive oversized frames */
1636+
if (bp->caps | MACB_CAPS_JUMBO)
1637+
config |= MACB_BIT(JFRAME); /* Enable jumbo frames */
1638+
else
1639+
config |= MACB_BIT(BIG); /* Receive oversized frames */
16371640
if (bp->dev->flags & IFF_PROMISC)
16381641
config |= MACB_BIT(CAF); /* Copy All Frames */
16391642
else if (macb_is_gem(bp) && bp->dev->features & NETIF_F_RXCSUM)
@@ -1642,8 +1645,13 @@ static void macb_init_hw(struct macb *bp)
16421645
config |= MACB_BIT(NBC); /* No BroadCast */
16431646
config |= macb_dbw(bp);
16441647
macb_writel(bp, NCFGR, config);
1648+
if ((bp->caps | MACB_CAPS_JUMBO) && bp->jumbo_max_len)
1649+
gem_writel(bp, JML, bp->jumbo_max_len);
16451650
bp->speed = SPEED_10;
16461651
bp->duplex = DUPLEX_HALF;
1652+
bp->rx_frm_len_mask = MACB_RX_FRMLEN_MASK;
1653+
if (bp->caps | MACB_CAPS_JUMBO)
1654+
bp->rx_frm_len_mask = MACB_RX_JFRMLEN_MASK;
16471655

16481656
macb_configure_dma(bp);
16491657

@@ -2685,10 +2693,12 @@ static const struct macb_config emac_config = {
26852693
};
26862694

26872695
static const struct macb_config zynqmp_config = {
2688-
.caps = MACB_CAPS_SG_DISABLED | MACB_CAPS_GIGABIT_MODE_AVAILABLE,
2696+
.caps = MACB_CAPS_SG_DISABLED | MACB_CAPS_GIGABIT_MODE_AVAILABLE |
2697+
MACB_CAPS_JUMBO,
26892698
.dma_burst_length = 16,
26902699
.clk_init = macb_clk_init,
26912700
.init = macb_init,
2701+
.jumbo_max_len = 10240,
26922702
};
26932703

26942704
static const struct of_device_id macb_dt_ids[] = {
@@ -2770,6 +2780,10 @@ static int macb_probe(struct platform_device *pdev)
27702780
bp->pclk = pclk;
27712781
bp->hclk = hclk;
27722782
bp->tx_clk = tx_clk;
2783+
if (macb_config->jumbo_max_len) {
2784+
bp->jumbo_max_len = macb_config->jumbo_max_len;
2785+
}
2786+
27732787
spin_lock_init(&bp->lock);
27742788

27752789
/* setup capabilities */

drivers/net/ethernet/cadence/macb.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@
7171
#define GEM_NCFGR 0x0004 /* Network Config */
7272
#define GEM_USRIO 0x000c /* User IO */
7373
#define GEM_DMACFG 0x0010 /* DMA Configuration */
74+
#define GEM_JML 0x0048 /* Jumbo Max Length */
7475
#define GEM_HRB 0x0080 /* Hash Bottom */
7576
#define GEM_HRT 0x0084 /* Hash Top */
7677
#define GEM_SA1B 0x0088 /* Specific1 Bottom */
@@ -397,6 +398,7 @@
397398
#define MACB_CAPS_GIGABIT_MODE_AVAILABLE 0x20000000
398399
#define MACB_CAPS_SG_DISABLED 0x40000000
399400
#define MACB_CAPS_MACB_IS_GEM 0x80000000
401+
#define MACB_CAPS_JUMBO 0x00000008
400402

401403
/* Bit manipulation macros */
402404
#define MACB_BIT(name) \
@@ -514,6 +516,9 @@ struct macb_dma_desc {
514516
#define MACB_RX_BROADCAST_OFFSET 31
515517
#define MACB_RX_BROADCAST_SIZE 1
516518

519+
#define MACB_RX_FRMLEN_MASK 0xFFF
520+
#define MACB_RX_JFRMLEN_MASK 0x3FFF
521+
517522
/* RX checksum offload disabled: bit 24 clear in NCFGR */
518523
#define GEM_RX_TYPEID_MATCH_OFFSET 22
519524
#define GEM_RX_TYPEID_MATCH_SIZE 2
@@ -757,6 +762,7 @@ struct macb_config {
757762
int (*clk_init)(struct platform_device *pdev, struct clk **pclk,
758763
struct clk **hclk, struct clk **tx_clk);
759764
int (*init)(struct platform_device *pdev);
765+
int jumbo_max_len;
760766
};
761767

762768
struct macb_queue {
@@ -826,6 +832,9 @@ struct macb {
826832
unsigned int max_tx_length;
827833

828834
u64 ethtool_stats[GEM_STATS_LEN];
835+
836+
unsigned int rx_frm_len_mask;
837+
unsigned int jumbo_max_len;
829838
};
830839

831840
static inline bool macb_is_gem(struct macb *bp)

0 commit comments

Comments
 (0)