Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flicker Period? #444

Closed
bhjelstrom opened this issue Jan 24, 2023 · 4 comments
Closed

Flicker Period? #444

bhjelstrom opened this issue Jan 24, 2023 · 4 comments

Comments

@bhjelstrom
Copy link

Looking for an example utilizing the RPI IPA AGC's SetFlickerPeriod(). Getting pretty bad banding at low exposures which is a regression from the legacy stack.

@davidplowman
Copy link
Collaborator

Just out of curiosity, what do you mean by "low exposures"? The legacy stack had no ability to suppress flicker when the exposure time was less than 10ms. Would you be able to report the exposure time and gain you're seeing in both the "good" and "bad" cases? Thanks!

In the meantime I'll look into this problem. The principal issue, I believe, is that libcamera has no controls that plumb into the SetFlickerPeriod() method.

@bhjelstrom
Copy link
Author

Hi David, I was most likely mistaken about this being a regression. We are exploring a fundamentally different use case that simply highlights the flicker issue. Our old use-case called for completely black images which made flicker unnoticeable, and our new use-case calls for slightly brighter images. We are definitely always under 10ms. Will play with the frame period in the meantime, but access to SetFlickerPeriod will surely help!
Thanks!

@naushir
Copy link
Collaborator

naushir commented Jul 25, 2023

This has now been merged into libcamera. The accompanying change for libcamera-apps to enable flicker control is at #544.

@naushir
Copy link
Collaborator

naushir commented Jul 26, 2023

Flicker control is now available with the --flicker-period command line option. Note that you need the very latest libcamera + libcamera-apps top-of-tree builds for this to be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants