-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two minor issues with the cmake install procedure #1
Comments
Yes, it's just meant for building the /opt/vc/lib binaries. |
I don't understand why isn't this repo complete? So this must be used combined with firmware repo? Makes no sense. ag |
yeah, it makes more sense to build all of the userspace tools/libs from the userland repo |
Indeed. That was my view too. |
It should be a complete replacement (IMHO), it has the bcm_host implementation, but it's not connected to anything... I'm thinking it's still a work in progress or was this just a release and forget it move by the RPI foundation? why is this not fixed yet? |
bcm_host and hello_pi demos are now included. |
@popcornmix I could kiss you! but you will have to settle for a beer. |
@popcornmix seems like you missed "bcm_host.h", I see it got added to the repo but no content (besides license information). Is it getting deprecated? EDIT: *** found the problem *** - pull request sent |
As far as I could see, bcm_host.h was correct, but in wrong location. I've moved it. Is that okay? |
Thanks popcornmix! |
@popcornmix it was more than just the location, look at your own commit (83e1597), but thanks for fixing it anyway. 👍 |
makefiles/cmake/vmcs.cmake - Line 54 - makefiles/cmake/scripts/install_vmcs is missing from repo.
interface/vchiq_arm/CMakeLists.txt - Line 9 - etc/10-vchiq.rules is also missing.
Other than that it builds and installs fine natively on the Pi.
Thanks Broadcom!
Update:
Oh wait, it's also missing bcm_host.h and doesn't install a lot of interface headers...
Maybe repo was never ment as a complete /opt/vc replacement, in that case install procedure is probably not a big deal :)
The text was updated successfully, but these errors were encountered: