Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why SIGINT rather than beforeExit? #247

Closed
arcanis opened this issue Mar 5, 2020 · 3 comments
Closed

Why SIGINT rather than beforeExit? #247

arcanis opened this issue Mar 5, 2020 · 3 comments

Comments

@arcanis
Copy link

arcanis commented Mar 5, 2020

I'm using tmp in Yarn, but it causes problems where other SIGINT handlers aren't registered due to tmp overriding them with its own (I'm not entirely sure about the order of execution to be honest, but it's clear tmp has a role into this).

Why is node-tmp catching SIGINT in the first place rather than using the beforeExit handler?

@lpgera
Copy link

lpgera commented Mar 23, 2020

Yeah, this issue caused a massive headache for me too. Our production web app relies on a SIGINT handler to shut down (or reload) gracefully, which it started to not do after we've included this package.

@CleyFaye
Copy link

CleyFaye commented Apr 2, 2020

edit: I just saw #233 . Guess it's soon going to not be an issue anymore.

@raszi
Copy link
Owner

raszi commented Apr 9, 2020

Closed by #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants