-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking changes viped from changelog #272
Comments
Thank you for pointing this out. We had a few bug fixes erroneously labelled as breaking changes.
and similar such cases. But we also lost some information in the process of switching to lerna-changelog, namely the information that was entered manually and for which no PR exists, e.g.
and similar such information. However, we broke the system somewhat when forcing all paths to be relative to the configured tmpdir.
These changes are now labelled as either bug fixes or enhancements or internal. The need for all paths to be relative to the configured tmpdir along with also limitations on the tmp names and paths did raise some issues and we are trying to address that with the future typescript rewrite. And, we must make sure that we have a PR for every change we make so that it gets labelled correctly and will show up in the automatically generated changelog. |
Just want to point out, that for a package that's downloaded tens of millions of times per week, you guys merged a PR (#253) that essentially removed all breaking change warnings from the changelog.
Upgrading dependencies for a project is a tedious task; changelogs help with that. I understand the intent was to improve the changelog, but this clearly removed valuable info.
Please take my feedback as constructive in the hopes that it improves your work on a highly used library in the future.
And please consider reinstating breaking changes into your changelog so that other developers don't have to spend valuable time going through your git history to figure out what footguns they upgraded to.
The text was updated successfully, but these errors were encountered: