fix(stylize)!: add Stylize impl for String #466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the
Stylize
trait is already implemented for&str
whichextends to
String
, it is not implemented forString
itself. Thiscommit adds an impl of Stylize that returns a Span<'static> for
String
so that code can call Stylize methods on temporary
String
s.E.g. the following now compiles instead of failing with a compile error
about referencing a temporary value:
BREAKING CHANGE: This may break some code that expects to call Stylize
methods on
String
values and then use the String value later. Thiswill now fail to compile because the String is consumed by set_style
instead of a slice being created and consumed.
This can be fixed by cloning the
String
. E.g.:Fixes https://discord.com/channels/1070692720437383208/1072907135664529508/1148229700821450833