docs(terminal): add docs for terminal module #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles and
kdheepak
as code owners
Codecov Report
@@ Coverage Diff @@
## main #486 +/- ##
=======================================
Coverage 90.16% 90.16%
=======================================
Files 41 41
Lines 11277 11277
=======================================
Hits 10168 10168
Misses 1109 1109
|
joshka
force-pushed
the
docs-terminal
branch
from
d41f38d
to
f0de9b9
Compare
|
kdheepak
reviewed
Sep 12, 2023
kdheepak
reviewed
Sep 12, 2023
kdheepak
approved these changes
Sep 12, 2023
joshka
force-pushed
the
docs-terminal
branch
3 times, most recently
from
13c07ff
to
b8566d7
Compare
kdheepak
approved these changes
Sep 12, 2023
joshka
force-pushed
the
docs-terminal
branch
from
b8566d7
to
20170d0
Compare
- moves the impl Terminal block up to be closer to the type definition
joshka
force-pushed
the
docs-terminal
branch
from
20170d0
to
69a4723
Compare
|
One last rebase for conflicts -whew! |
kdheepak
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in doc changes from #280 in an attempt to simplify that PR (more to come for other types).