fix(Barchart): horizontal labels were not displayed #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valentin271
requested review from
orhun,
mindoodoo,
sayanarijit,
sophacles,
joshka and
kdheepak
as code owners
Codecov Report
@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 89.98% 90.04% +0.06%
==========================================
Files 40 40
Lines 11160 11245 +85
==========================================
+ Hits 10042 10126 +84
- Misses 1118 1119 +1
|
karthago1
reviewed
Sep 20, 2023
Valentin271
force-pushed
the
fix/horizontal-barchart-labels
branch
from
19ce368
to
5749466
Compare
|
Incorporated feedbacks in 5749466. Thanks @karthago1! |
Valentin271
force-pushed
the
fix/horizontal-barchart-labels
branch
from
5749466
to
bc0d27b
Compare
joshka
requested changes
Sep 22, 2023
Fixed horizontal bars label not displayed. Also adds ways to configure label truncation.
Valentin271
force-pushed
the
fix/horizontal-barchart-labels
branch
from
bc0d27b
to
776230d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed horizontal bars label not displayed.
Also adds ways to configure label truncation because it would be hard to use labels horizontally otherwise.
This fixes #499