feat(style): implement From trait for crossterm to Style related structs
#686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valentin271
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka and
kdheepak
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
=======================================
+ Coverage 91.3% 91.4% +0.1%
=======================================
Files 42 42
Lines 12992 13278 +286
=======================================
+ Hits 11868 12149 +281
- Misses 1124 1129 +5 ☔ View full report in Codecov by Sentry. |
joshka
requested changes
Dec 12, 2023
Valentin271
force-pushed
the
feat/into-style
branch
from
54d32e3
to
6373763
Compare
Valentin271
force-pushed
the
feat/into-style
branch
from
6373763
to
d23dd84
Compare
orhun
changed the title
From trait for crossterm to ratatui Style related structsFrom trait for crossterm to Style related structs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following
Fromimplementations:AttributetoModifierAttributestoModifierColortoColorContentStyletoStyleThis PR relates to #679. I've decided to split the work across multiple PRs to facilitate the reviewing process.