Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(layout): Accept IntoIterator for constraints #663

Merged
merged 2 commits into from
Dec 4, 2023
Merged

feat(layout): Accept IntoIterator for constraints #663

merged 2 commits into from
Dec 4, 2023

Conversation

joshka
Copy link
Member

@joshka joshka commented Dec 4, 2023

  • style(tabs): fix doc formatting
  • feat(layout): Accept IntoIterator for constraints

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6a6e9dd) 90.6% compared to head (11b3be0) 90.8%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/layout.rs 93.1% 3 Missing ⚠️
src/widgets/tabs.rs 96.9% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main    #663     +/-   ##
=======================================
+ Coverage   90.6%   90.8%   +0.1%     
=======================================
  Files         42      42             
  Lines      12311   12349     +38     
=======================================
+ Hits       11163   11220     +57     
+ Misses      1148    1129     -19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka joshka changed the title table width iterable feat(layout): Accept IntoIterator for constraints Dec 4, 2023
orhun
orhun reviewed Dec 4, 2023
View reviewed changes
src/layout.rs Show resolved Hide resolved
@orhun orhun mentioned this pull request Dec 4, 2023
Merged
@orhun
Copy link
Member

orhun commented Dec 4, 2023

Not sure 7b0ef3d belongs to this PR 🐻

@joshka
fix(tabs): fixup tests broken by semantic merge conflict
0d69c7f 
Two changes without any line overlap caused the tabs tests to break
@joshka
feat(layout): Accept IntoIterator for constraints
11b3be0 
Layout and Table now accept IntoIterator for constraints with an Item
that is AsRef<Constraint>. This allows pretty much any collection of
constraints to be passed to the layout functions including arrays,
vectors, slices, and iterators (without having to call collect() on
them).
@joshka joshka merged commit 6b2efd0 into main Dec 4, 2023
33 checks passed
@joshka joshka deleted the table-width-iterable branch December 4, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

@mindoodoo mindoodoo Awaiting requested review from mindoodoo

@sayanarijit sayanarijit Awaiting requested review from sayanarijit

@kdheepak kdheepak Awaiting requested review from kdheepak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshka @orhun