feat(List)!: new now accepts IntoIterator<Item = Into<ListItem>>

[Valentin271]

This allows to build list like

List::new(["Item 1", "Item 2"])

Fixes #670

I think this should be added for 0.26 to not add too much breaking change for 0.25. Moreover there's another breaking change for list coming with #671. It makes sense to release them together.

[codecov]

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (8bfd666) 90.9% compared to head (511c86d) 90.9%.

Files	Patch %	Lines
src/widgets/list.rs	85.9%	9 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #672     +/-   ##
=======================================
- Coverage   90.9%   90.9%   -0.1%     
=======================================
  Files         42      42             
  Lines      12612   12671     +59     
=======================================
+ Hits       11469   11519     +50     
- Misses      1143    1152      +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joshka]

I think this breaks things in a good way (i.e. on an empty list of items with indeterminate type), so we can probably take it in the next major (0.25.0).

Needs a couple more things:

• some tests to show it works for a few of the assorted types.
• an entry in the breaking changes doc to explain how old code will fail (and corresponding changelog message in the commit

Let's also add an items() method so that List::default().items(...) works. What do you think?

[Valentin271]

Let's go for 0.25 then, it shouldn't really break any code anyway since there weren't an items method before. So creating an empty list was pointless.

Let's also add an items() method so that List::default().items(...) works. What do you think?

Agree, so it lines up with table once #638 is merged

[Valentin271]

Should be all good now. Hope the commit message is good enough, took inspiration from this one 37c70db

[joshka]

LGTM - the must_use fix should probably be added before merging this though.

[Valentin271]

I also fixed some typos and missing links in the breaking-change file. Weird that typos-cli didn't catch them.