feat(widgets): Collect iterator of Row into Table
#774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka,
kdheepak and
Valentin271
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #774 +/- ##
=====================================
Coverage 92.4% 92.4%
=====================================
Files 57 57
Lines 15000 15024 +24
=====================================
+ Hits 13866 13890 +24
Misses 1134 1134 ☔ View full report in Codecov by Sentry. |
Valentin271
previously requested changes
Jan 10, 2024
joshka
reviewed
Jan 10, 2024
joshka
requested changes
Jan 11, 2024
There was a problem hiding this comment.
LGTM - just missing the full breaking change description.
commit message for the changelog should probably be something like
feat(table)!: accept IntoItertor<Into<Row>> for constructors
Table::new() now accepts ...
Table::from_iterator() ...
BREAKING CHANGE:
Calls to Table::new() passing rows as as an infered type
(e.g. `vec![]`) will no longer compile because the compiler
cannot to infer the type. (**reword this a bit better**)
A follow-up from ratatui#755, allowing any iterator whose item is convertible into `Row` to be collected into a `Table`. Where previously, `Table::new` accepted `IntoIterator<Item = Row>`, it now accepts `IntoIterator<Item: Into<Row>>`. BREAKING CHANGE: The compiler can no longer infer the element type of the container passed to `Table::new()`. For example, `Table::new(vec![], widths)` will no longer compile, as the type of `vec![]` can no longer be inferred.
Lunderberg
force-pushed
the
table_from_iterator
branch
from
b17bdc6
to
afb6689
Compare
|
Thanks again for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up from #755, allowing any iterator whose item is convertible into
Rowto be collected into aTable.