Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Storage methods are incompatible with HttpFoundation 6.* #969

Open
liviucmg opened this issue Jun 17, 2022 · 0 comments
Open

Session Storage methods are incompatible with HttpFoundation 6.* #969

liviucmg opened this issue Jun 17, 2022 · 0 comments

Comments

@liviucmg
Copy link

Some methods are missing the return types, so we're getting the following errors:

In VirtualSessionStorage.php line 54:
                                                                                                                                                                                                                 
  Compile Error: Declaration of Ratchet\Session\Storage\VirtualSessionStorage::regenerate($destroy = false, $lifetime = null) must be compatible with Symfony\Component\HttpFoundation\Session\Storage\NativeSe  
  ssionStorage::regenerate(bool $destroy = false, ?int $lifetime = null): bool 
In VirtualProxy.php line 29:
                                                                                                                                                                                                   
  Compile Error: Declaration of Ratchet\Session\Storage\Proxy\VirtualProxy::getId() must be compatible with Symfony\Component\HttpFoundation\Session\Storage\Proxy\AbstractProxy::getId(): string  

We're currently using symfony/http-foundation v6.1.1.

The fixes are straightforward, and I will submit a PR shortly.

Related to #963.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant