Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect after a succesful paypal donation #268

Open
AnisotropicDefixation opened this issue Oct 31, 2020 · 1 comment
Open

Redirect after a succesful paypal donation #268

AnisotropicDefixation opened this issue Oct 31, 2020 · 1 comment

Comments

@AnisotropicDefixation
Copy link

I am talking about the intended redirect to the "?module=donate&action=complete page.

It seems to not work no matter what. Adding the page to paypal's automatic redirection does nothing either.

After a donation is made, you're just sent to ?module=main, there isn't any attempt to reach the intended page.

I've played around for a bit and I think the issue might be coming from this bit in preprocess.php:

if ($params->get('merchant_return_link')

It seems like merchant_return_link isn't being sent by paypal during the IPN confirmation, although even removing that check doesn't help either.

@sanasol
Copy link
Member

sanasol commented Nov 2, 2020

Only usage of donate complete page is here:

if ($params->get('merchant_return_link') && $ppReturn['txn_id'] && $ppReturn['txn_type'] &&
$ppReturn['first_name'] && $ppReturn['last_name'] && $ppReturn['item_name'] && $ppReturn['verify_sign']) {
$session->setPpReturnData($ppReturn);
$this->redirect($this->url('donate', 'complete'));
}

Not sure is actually ever triggered or not. But anyway seems useless, there is no any actions or logic on that page.

But return url by default is module main
https://github.com/rathena/FluxCP/blob/master/data/paypal/button.php#L20
So you can change it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New Items
Development

No branches or pull requests

3 participants