-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conda package for dask-ms #103
Comments
Hi @sebastian-luna-valero. Thanks for reaching out. In principle yes, although my experience with conda and conda packaging is limited -- I've worked with pypi exclusively as a release mechanism up till this point. I'm keen to try.
I feel that these are the core dependencies:
Adding the xarray optional extra
Adding the testing optional extra expands it
distributed is not yet a dependency, although I might try to detect for it in the code itself. |
Also note that I'm aiming to release 0.2.4 in the next week or so. |
Great, thanks @sjperkins Could you please let me know once version 0.2.4 has been released so I start working on the conda package? Best regards, |
By the way, would you (or anyone else) like to be listed as a recipe maintainer? |
Initial recipe here: conda-forge/staged-recipes#11321 We can easily update the recipe to include more maintainers. Could you confirm whether I should include the following license title:
|
Could you outline what this entails? I'd be happy to look at a URL. |
I've updated the year in #105 so this should now change to:
|
It will give you push access to the conda-forge feedstock for the dask-ms package so you have permissions to update it, and approve/reject PRs. See examples of conda-forge feedstocks here: https://conda-forge.org/feedstocks/ As it is configured now, every new release of More general info is available here: https://conda-forge.org/docs |
OK thanks, I'd be happy to be a maintainer here. @o-smirnov it might make sense to make you or someone else a maintainer too in order to reduce the bus factor. |
dask-ms has a full test suite that is designed to be run with pytest. It's currently run on travis as follows: https://github.com/ska-sa/dask-ms/blob/master/.travis/python36.docker Is this something that you would be prepared to adapt for whatever CI environment runs on conda so that I could learn how this is done, or would you prefer me to set this up? |
That's great, many thanks. Given that you already test it before PyPI releases it probably doesn't make sense to repeat the full suite in conda again. Could you please provide a few more python imports to add to this recipe just as a sanity check? I will wait for @o-smirnov to confirm, thanks! |
I think these are the most important imports:
|
dask-ms 0.2.4 has been released on pypi: https://pypi.org/project/dask-ms/0.2.4/ and is tagged in this repo as 0.2.4 |
Thanks for letting me know @sjperkins Conda package has been created and uploaded to the |
Hi,
I would like to create a
conda-forge
package fordask-ms
.I have an initial conda environment that seems to work:
Would you be happy to assist if I find issues?
Best regards,
Sebastian
The text was updated successfully, but these errors were encountered: